[DBMON-3271] add new obfuscator options to customize SQL obfuscation and normalization #16429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
documentation
integration/mysql
integration/postgres
integration/sqlserver
labels
10 tasks
lu-zhengda
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
nenadnoveljic
approved these changes
Dec 19, 2023
github-actions bot
pushed a commit
to wolf31o2/integrations-core
that referenced
this pull request
Dec 19, 2023
…and normalization (DataDog#16429) * add new obfuscator options to customize SQL obfuscation and normalization * add changelogs * fix lint 4272b9a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds new SQL obfuscation options to
postgres,mysqlandsqlserverintegration. The new options includesobfuscation_mode: enables/disables SQL obfuscation with new obfuscator fromgo-sqllexerremove_space_between_parentheses: remove spaces between parentheses in your normalized SQL statements.keep_null: keep the keywordNULLin your obfuscated SQL statements.keep_boolean: keep the keywordsTRUEandFALSEin your obfuscated SQL statements.keep_positional_parameter: keep positional parameters (e.g.$1) in your obfuscated SQL statements.keep_trailing_semicolon: keep trailing semicolons in your normalized SQL statements.keep_identifier_quotation: keep identifier quotations (e.g."my_table") in your normalized SQL statements.The new options are depend on DataDog/datadog-agent#21568
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.