Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[DBMON-2989] report sql obfuscation error count (#15990)" #16439

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

lu-zhengda
Copy link
Contributor

@lu-zhengda lu-zhengda commented Dec 15, 2023

What does this PR do?

[INCIDENT-24014] This reverts commit 5ba30fc.

Motivation

We've noticed increased memory usage with databases with high cardinality, for example, Postgres with exploded pg_stat_statements, due to this change.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #16439 (68e2cdc) into master (ed0b328) will increase coverage by 0.10%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mysql 87.41% <ø> (+0.05%) ⬆️
postgres 92.35% <ø> (+0.07%) ⬆️
presto ?
solr ?
sqlserver 89.85% <ø> (+0.01%) ⬆️
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Dec 15, 2023

Test Results

     48 files       48 suites   1h 19m 29s ⏱️
   676 tests    662 ✔️   14 💤 0
5 990 runs  5 648 ✔️ 342 💤 0

Results for commit 68e2cdc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, should we drop this metric from metadata.csv as well, or does it still get reported elsewhere?

If we're dropping it from metadata.csv, I'd argue that this warrants a major version bump as the change becomes essentially breaking for customers that use this metric.

@lu-zhengda
Copy link
Contributor Author

lu-zhengda commented Dec 15, 2023

@iliakur this metric dd.postgres|mysql|sqlserver.obfuscation.error was considered for internal debugging uses and was not included in the metadata.csv. They are newly added for 7.50 but not being released yet.

@iliakur iliakur self-requested a review December 16, 2023 13:09
@lu-zhengda lu-zhengda merged commit 792f7bb into master Dec 16, 2023
53 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/revert-15990 branch December 16, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants