Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBMON-3300] collect function & count metrics for auto discovered databases #16530

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

lu-zhengda
Copy link
Contributor

What does this PR do?

Postgres integration will start collecting function & count metrics for auto discovered databases.

Motivation

Function & count metrics are database specific, but they were not being properly collected for auto discovered databases.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@ghost ghost added the integration/postgres label Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b70fce7) 90.53% compared to head (518d5ae) 90.63%.
Report is 107 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
postgres 92.43% <96.96%> (+0.05%) ⬆️
presto ?
solr ?
tomcat ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

github-actions bot commented Jan 4, 2024

Test Results

   16 files     16 suites   20m 28s ⏱️
  266 tests   264 ✅   2 💤 0 ❌
2 136 runs  2 032 ✅ 104 💤 0 ❌

Results for commit 518d5ae.

@lu-zhengda lu-zhengda merged commit c035233 into master Jan 24, 2024
39 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/DBMON-3300 branch January 24, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants