update default table schema collection limit to 300 #16880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-zhengda
previously approved these changes
Feb 14, 2024
lu-zhengda
reviewed
Feb 14, 2024
EmmaOnThursday
force-pushed
the
update-max-tables-collection
branch
from
5ef0fe4
to
6d83a97
Compare
EmmaOnThursday
force-pushed
the
update-max-tables-collection
branch
from
6d83a97
to
100dd20
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Test Results 16 files 16 suites 20m 51s ⏱️ Results for commit 100dd20. |
lu-zhengda
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBMON-3483
What does this PR do?
Until recently we required table metrics to be enabled to collect table information via schemas collection. Relation metrics have a default limit of 300 relations, this provided a hidden default of 300 relations we would collect via schema collection.
Since we no longer require relation metrics for schema collection, we are lowering the default relations collection limit for schemas to match the previous hidden default.
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.