Set statement_timeout at session level & use reset_val as setting when source is session #17264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR
reset_val
in pg_settings query whensource
equals tosession
.Motivation
https://datadoghq.atlassian.net/browse/DBMON-3728
Prior to the change, the
statement_timeout
setting collected frompg_settings
is set by datadog integration connection (default to 5s). This does not reflect the database levelstatement_timeout
setting and is often misleading. In this PR, we set the statement_timeout after the connection is established. This way we can do a simple checkcase when source = 'session' then reset_val else setting end as setting
to retrieve the server level setting.Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.