Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value for pg_stat_statements_view #17400

Conversation

sethsamuel
Copy link
Contributor

What does this PR do?

Fixes the default value for pg_stat_statements_view in the example config

Motivation

Some customers are confused by the current default, which is not the correct default.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

nenadnoveljic
nenadnoveljic previously approved these changes Apr 16, 2024
Copy link
Contributor

@nenadnoveljic nenadnoveljic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but the CI errors have to be fixed before merging.

Copy link

github-actions bot commented Apr 16, 2024

Test Results

   16 files     16 suites   20m 54s ⏱️
  286 tests   284 ✅   2 💤 0 ❌
2 296 runs  2 181 ✅ 115 💤 0 ❌

Results for commit 7c50551.

♻️ This comment has been updated with latest results.

@sethsamuel sethsamuel merged commit 7661ed2 into master Apr 17, 2024
34 checks passed
@sethsamuel sethsamuel deleted the seth.samuel/DBMON-3925-Postgres-Configuration-Not-Used-Correctly branch April 17, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants