Correcting duplicate metric name, add index_rows_fetched #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzussa
approved these changes
Jun 19, 2018
Correcting duplicate metric name: postgresql.index_rows_fetched A new name should be defined to prevent confusion and incorrect data in graph. Same as #1761
masci
force-pushed
the
Marcquero-patch-2-1
branch
from
020484b
to
500b7cf
Compare
|
LGTM |
masci
changed the title
masci
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Correcting duplicate metric name: postgresql.index_rows_fetched
This metric name have been set for both REL_METRICS and IDX_METRICS.
So, I'd suggest renaming postgresql.index_rel_rows_fetched metric for REL_METRICS.
Motivation
Correcting duplicate metric name: postgresql.index_rows_fetched
A new name should be defined to prevent confusion and incorrect data in graph.
Similar to #1761