Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dbm][postgres] adds param global_view_db for database_autodiscovery #18037

Merged
merged 5 commits into from
Aug 16, 2024
Merged

[dbm][postgres] adds param global_view_db for database_autodiscovery #18037

merged 5 commits into from
Aug 16, 2024

Conversation

dalextorres
Copy link
Contributor

What does this PR do?

Adds a param to specify which database the agent should connect to perform database_autodiscovery operations

Motivation

There are some platforms which don't give access to 'postgres' db to users, which make the feature unusable.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dalextorres dalextorres requested review from a team as code owners July 12, 2024 19:20
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

1 similar comment
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@dalextorres dalextorres force-pushed the alex.torres/postgres-default-global-view branch from c35b04a to 51fa161 Compare July 12, 2024 19:30
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@dalextorres dalextorres force-pushed the alex.torres/postgres-default-global-view branch from 267094d to dbd7513 Compare July 12, 2024 19:53
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

1 similar comment
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (c4a3649) to head (fc3aed0).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
postgres 93.05% <100.00%> (+10.63%) ⬆️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@dalextorres dalextorres force-pushed the alex.torres/postgres-default-global-view branch from dbd7513 to bd8f9aa Compare July 12, 2024 20:34
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@dalextorres dalextorres force-pushed the alex.torres/postgres-default-global-view branch from bd8f9aa to 62f0641 Compare July 15, 2024 14:11
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@dalextorres dalextorres force-pushed the alex.torres/postgres-default-global-view branch from 62f0641 to 771bf14 Compare August 16, 2024 15:57
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@dalextorres dalextorres force-pushed the alex.torres/postgres-default-global-view branch from 771bf14 to 0be6167 Compare August 16, 2024 16:02
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@dalextorres dalextorres force-pushed the alex.torres/postgres-default-global-view branch from 0be6167 to c7109e1 Compare August 16, 2024 16:06
@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions GitHub Actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@lu-zhengda lu-zhengda merged commit b0a19fd into master Aug 16, 2024
38 checks passed
@lu-zhengda lu-zhengda deleted the alex.torres/postgres-default-global-view branch August 16, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-zhengda lu-zhengda lu-zhengda approved these changes

Assignees
No one assigned
Labels
documentation integration/postgres team/agent-integrations team/database-monitoring-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalextorres @lu-zhengda