Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hdbcli dependency #18185

Merged
merged 1 commit into from
Aug 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sap_hana/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ The SAP HANA check is included in the [Datadog Agent][2] package. To use this in
For Unix:

```text
sudo -Hu dd-agent /opt/datadog-agent/embedded/bin/pip install hdbcli==2.10.15
sudo -Hu dd-agent /opt/datadog-agent/embedded/bin/pip install hdbcli==2.21.28
```

For Windows:

```text
"C:\Program Files\Datadog\Datadog Agent\embedded<PYTHON_MAJOR_VERSION>\python.exe" -m pip install hdbcli==2.10.15
"C:\Program Files\Datadog\Datadog Agent\embedded<PYTHON_MAJOR_VERSION>\python.exe" -m pip install hdbcli==2.21.28
```

#### Prepare HANA
Expand Down
2 changes: 1 addition & 1 deletion sap_hana/hatch.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[envs.default]
dependencies = [
"hdbcli==2.10.15",
"hdbcli==2.21.28",
]

[[envs.default.matrix]]
Expand Down
2 changes: 1 addition & 1 deletion sap_hana/tests/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
CONFIG = {'server': SERVER, 'port': PORT, 'username': 'datadog', 'password': 'Datadog9000', 'timeout': TIMEOUT}
ADMIN_CONFIG = {'server': SERVER, 'port': PORT, 'username': 'system', 'password': 'Admin1337'}

E2E_METADATA = {'start_commands': ['pip install hdbcli==2.10.15']}
E2E_METADATA = {'start_commands': ['pip install hdbcli==2.21.28']}

CAN_CONNECT_SERVICE_CHECK = 'sap_hana.{}'.format(SapHanaCheck.SERVICE_CHECK_CONNECT)

Expand Down
Loading