Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce log spam on kubernetes tagging #1830

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Reduce log spam on kubernetes tagging #1830

merged 1 commit into from
Jul 2, 2018

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Jun 29, 2018

The kubelet check calls the golang tagger to tag metrics. The python glue passed queries with None or "" (empty) cids, causing log spam on the golang side.
Filter these out on the python side

2018-06-28 14:22:57 UTC | WARN | (tagger.go:246 in Tag) | error collecting from kubelet: uid None not found in pod list
2018-06-28 14:22:57 UTC | WARN | (tagger.go:246 in Tag) | error collecting from kube-metadata-collector: uid None not found in pod list

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
    - [ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@xvello xvello added this to the 6.3.2 milestone Jun 29, 2018
@xvello xvello requested a review from a team as a code owner June 29, 2018 15:10
mfpierre
mfpierre approved these changes Jun 29, 2018
View reviewed changes
Copy link
Contributor

@mfpierre mfpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xvello xvello merged commit 291c735 into master Jul 2, 2018
@xvello xvello deleted the xvello/cid-none branch July 2, 2018 12:03
nmuesch pushed a commit that referenced this pull request Jul 2, 2018
@xvello @nmuesch
ignore empty cids without calling the tagger (#1830)
7e5d7de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

@mfpierre mfpierre mfpierre approved these changes

Assignees
No one assigned
Labels
containers integration/kubelet
Projects
None yet
Milestone
6.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@xvello @masci @mfpierre