Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sy/porting to master2 #18530

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Sy/porting to master2 #18530

wants to merge 4 commits into from

Conversation

steveny91
Copy link
Contributor

What does this PR do?

Changelogs

@steveny91 steveny91 requested review from a team as code owners September 6, 2024 20:55
alai97
alai97 previously approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some capitalization nits

hazelcast/CHANGELOG.md Outdated Show resolved Hide resolved
cisco_aci/CHANGELOG.md Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (6498b27) to head (46ac5b3).
Report is 76 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
cisco_aci 94.93% <100.00%> (ø)
hazelcast 92.30% <100.00%> (ø)
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@steveny91 @alai97
Update hazelcast/CHANGELOG.md
53d6d12 
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
@steveny91 @alai97
Update cisco_aci/CHANGELOG.md
46ac5b3 
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliakur iliakur iliakur approved these changes

@alai97 alai97 alai97 approved these changes

Assignees
No one assigned
Labels
documentation integration/cisco_aci integration/hazelcast qa/skip-qa Automatically skip this PR for the next QA release team/agent-integrations team/documentation team/network-device-monitoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveny91 @iliakur @alai97