Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEMINT-122] DDSaaS: Brevo: Integration v1.0.0 #18564

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

rajshah-crest
Copy link

What does this PR do?

This is a initial release PR of Brevo integration including all the required assets i.e. Pipeline, Dashboard and Monitors

Additional Notes

  • This integration is webhook based and so Crawler will not be used.
  • Datadog team will be required to add UI component for generation of webhook URLs in the configuration tile. Two URLs will be created, with both URLs having the ddsource query parameter set to brevo. The service query parameter will be set to marketing-events for marketing events and transactional-events for transactional events.
  • The assets are available in our sandbox and can be shared separately with the required teams.

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
[ ] If you need to backport this PR to another branch, you can add the backport/ label to the PR and it will automatically open a backport PR once this one is merged

@rajshah-crest rajshah-crest marked this pull request as ready for review September 13, 2024 12:17
@rajshah-crest rajshah-crest requested a review from a team as a code owner September 13, 2024 12:17
@estherk15 estherk15 added the editorial review Waiting on a more in-depth review from a docs team editor label Sep 13, 2024
brevo/README.md Outdated Show resolved Hide resolved
brevo/README.md Outdated Show resolved Hide resolved
brevo/README.md Outdated Show resolved Hide resolved
brevo/README.md Outdated Show resolved Hide resolved
brevo/README.md Outdated Show resolved Hide resolved
brevo/README.md Outdated Show resolved Hide resolved
brevo/README.md Outdated Show resolved Hide resolved
@dj0well dj0well changed the title DDSaaS: Brevo: Integration v1.0.0 [SIEMINT-122] DDSaaS: Brevo: Integration v1.0.0 Sep 23, 2024
estherk15
estherk15 previously approved these changes Sep 23, 2024
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those details! Looks good.

"version": 2,
"created_at": "2024-09-11",
"last_updated_at": "2024-09-11",
"title": "[Brevo] High Block Rate by Subject",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "[Brevo] High Block Rate by Subject",
"title": "High Block Rate by Subject",

"created_at": "2024-09-11",
"last_updated_at": "2024-09-11",
"title": "[Brevo] High Block Rate by Subject",
"description": "Monitors block rates for transactional emails by subject line. A high block rate may indicate that unsubscribed recipients are still receiving emails. Helps identify and resolve problems to improve the deliverability of transactional messages.",
Copy link
Contributor

@estherk15 estherk15 Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Monitors block rates for transactional emails by subject line. A high block rate may indicate that unsubscribed recipients are still receiving emails. Helps identify and resolve problems to improve the deliverability of transactional messages.",
"description": "This monitor alerts when block rates for transactional emails by subject line are higher than usual. A high block rate may indicate that unsubscribed recipients are still receiving emails. This monitor helps to identify and resolve problems to improve the deliverability of transactional messages.",

"version": 2,
"created_at": "2024-09-11",
"last_updated_at": "2024-09-11",
"title": "[Brevo] High Bounce Rate by Subject",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "[Brevo] High Bounce Rate by Subject",
"title": "High Bounce Rate by Subject",

"created_at": "2024-09-11",
"last_updated_at": "2024-09-11",
"title": "[Brevo] High Bounce Rate by Subject",
"description": "Tracks bounce rates for transactional emails by subject line. High bounce rates may indicate invalid addresses or server issues. Helps identify and resolve problems to improve the deliverability of transactional messages.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Tracks bounce rates for transactional emails by subject line. High bounce rates may indicate invalid addresses or server issues. Helps identify and resolve problems to improve the deliverability of transactional messages.",
"description": "This monitor tracks bounce rates for transactional emails by subject line. High bounce rates may indicate invalid addresses or server issues. Use this monitor to help identify and resolve problems to improve the deliverability of transactional messages.",

"version": 2,
"created_at": "2024-09-11",
"last_updated_at": "2024-09-11",
"title": "[Brevo] High Error Rate by Subject",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "[Brevo] High Error Rate by Subject",
"title": "High Error Rate by Subject",

"created_at": "2024-09-11",
"last_updated_at": "2024-09-11",
"title": "[Brevo] High Error Rate by Subject",
"description": "Monitors error rates for transactional emails by subject line. High error rates may indicate issues with content or recipient details. Helps identify and address problems to ensure reliable delivery of transactional emails.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Monitors error rates for transactional emails by subject line. High error rates may indicate issues with content or recipient details. Helps identify and address problems to ensure reliable delivery of transactional emails.",
"description": "Alerts when error rates for transactional emails by subject line are higher than usual. High error rates may indicate issues with content or recipient details. This monitor helps to identify and address problems to ensure reliable delivery of transactional emails.",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants