Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'six' usage from spark test #18640

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Sep 20, 2024

What does this PR do?

This involves a small refactor of the assertion setup. Was easier to do it this way than search/replace.

Motivation

Keeping this separate because it's not like the other changes related to six.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.95%. Comparing base (a47f5c6) to head (deafdda).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
spark 93.22% <100.00%> (-0.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@iliakur iliakur merged commit b357ac2 into master Sep 20, 2024
47 of 48 checks passed
@iliakur iliakur deleted the ik/AI-4133/drop-six-from-spark-test branch September 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants