Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version detection for Postgres v10+ #2208

Merged
merged 4 commits into from
Sep 11, 2018
Merged

Fix version detection for Postgres v10+ #2208

merged 4 commits into from
Sep 11, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Sep 11, 2018

Motivation

>>> [10, 0] >= [10, 0, 0]
False

@ofek ofek requested a review from a team as a code owner September 11, 2018 02:41
masci
masci approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 💯

masci
masci suggested changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@masci masci left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the tests before merging

@codecov-io
Copy link

codecov-io commented Sep 11, 2018 •
edited
Loading

Codecov Report

Merging #2208 into master will decrease coverage by 7.67%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2208      +/-   ##
==========================================
- Coverage   86.14%   78.47%   -7.68%     
==========================================
  Files         186        5     -181     
  Lines       13155      497   -12658     
  Branches     1375       88    -1287     
==========================================
- Hits        11333      390   -10943     
+ Misses       1435       74    -1361     
+ Partials      387       33     -354

gmmeyer
gmmeyer previously approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge it

@ofek ofek merged commit e3c7b59 into master Sep 11, 2018
@ofek ofek deleted the ofek/pg branch September 11, 2018 14:55
masci
masci reviewed Sep 11, 2018
View reviewed changes
postgres/datadog_checks/postgres/postgres.py Outdated
# return True if version is the same
return True

return False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deserved a test

ofek added a commit that referenced this pull request Sep 11, 2018
@ofek
Fix version detection for Postgres v10+ (#2208)
399cd01 
* Fix version detection for Postgres v10+
nmuesch pushed a commit that referenced this pull request Nov 1, 2018
@ofek @nmuesch
Fix version detection for Postgres v10+ (#2208)
2c3c1f3 
* Fix version detection for Postgres v10+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci requested changes

@gmmeyer gmmeyer gmmeyer approved these changes

Assignees
No one assigned
Labels
integration/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ofek @codecov-io @masci @gmmeyer