Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubelet rss and working set memory metrics #2390

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

mfpierre
Copy link
Contributor

What does this PR do?

Add kubelet rss and working set memory metrics

Motivation

Have better container memory usage monitoring

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #2390 into master will increase coverage by 7.22%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #2390      +/-   ##
==========================================
+ Coverage   79.83%   87.06%   +7.22%     
==========================================
  Files         206        8     -198     
  Lines       14168      881   -13287     
  Branches     1548      136    -1412     
==========================================
- Hits        11311      767   -10544     
+ Misses       2453       79    -2374     
+ Partials      404       35     -369

@mfpierre mfpierre force-pushed the mfpierre/add-kube-mem-metrics branch from 7247db5 to fc3449b Compare October 12, 2018 12:49
Copy link
Member

@hkaj hkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mfpierre mfpierre merged commit 88a04f2 into master Oct 12, 2018
@masci masci deleted the mfpierre/add-kube-mem-metrics branch November 13, 2018 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants