Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version detection for new development releases #2401

Merged
merged 1 commit into from
Oct 14, 2018
Merged

Fix version detection for new development releases #2401

merged 1 commit into from
Oct 14, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Oct 14, 2018

Motivation

Previously, beta was all they used. Now they use rc as well. We now accept any number of letters to be more future-proof.

@codecov-io
Copy link

Codecov Report

Merging #2401 into master will increase coverage by 0.24%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2401      +/-   ##
==========================================
+ Coverage   78.66%   78.91%   +0.24%     
==========================================
  Files         205        5     -200     
  Lines       14087      498   -13589     
  Branches     1524       88    -1436     
==========================================
- Hits        11082      393   -10689     
+ Misses       2601       73    -2528     
+ Partials      404       32     -372

Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🙇

@ofek ofek merged commit b4a2fd9 into master Oct 14, 2018
@ofek ofek deleted the ofek/pg branch October 14, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants