Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more cpu metrics #2595

Merged
merged 5 commits into from
Nov 22, 2018
Merged

Add more cpu metrics #2595

merged 5 commits into from
Nov 22, 2018

Conversation

hkaj
Copy link
Member

@hkaj hkaj commented Nov 15, 2018

What does this PR do?

Add more CPU metrics.

Motivation

User request.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@hkaj hkaj requested review from a team as code owners November 15, 2018 17:30
@hkaj hkaj changed the title Add more cpu metrics [kubelet] add more cpu metrics Nov 15, 2018
@codecov-io
Copy link

codecov-io commented Nov 15, 2018

Codecov Report

Merging #2595 into master will increase coverage by 5.63%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2595      +/-   ##
==========================================
+ Coverage   83.88%   89.52%   +5.63%     
==========================================
  Files         644       10     -634     
  Lines       36453     1088   -35365     
  Branches     4439      141    -4298     
==========================================
- Hits        30580      974   -29606     
+ Misses       4556       79    -4477     
+ Partials     1317       35    -1282

@hkaj hkaj force-pushed the haissam/kubelet-add-throttle branch from b22ff3f to 25c6687 Compare November 15, 2018 17:52
kubelet/metadata.csv Outdated Show resolved Hide resolved
xvello
xvello previously requested changes Nov 20, 2018
Copy link
Contributor

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good but one unit in the metadata

kubelet/metadata.csv Outdated Show resolved Hide resolved
@hkaj hkaj force-pushed the haissam/kubelet-add-throttle branch from 4bf2829 to bb86913 Compare November 22, 2018 12:34
@hkaj
Copy link
Member Author

hkaj commented Nov 22, 2018

@zippolyte should be good to go now

Copy link
Contributor

@zippolyte zippolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hkaj hkaj dismissed xvello’s stale review November 22, 2018 12:51

addressed these

@hkaj hkaj merged commit 5371ef9 into master Nov 22, 2018
@hkaj hkaj deleted the haissam/kubelet-add-throttle branch November 22, 2018 12:51
@ofek ofek changed the title [kubelet] add more cpu metrics Add more cpu metrics Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants