-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server
tag to metrics and service_check
#2928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2928 +/- ##
==========================================
+ Coverage 85.44% 85.85% +0.4%
==========================================
Files 676 9 -667
Lines 35517 735 -34782
Branches 4205 104 -4101
==========================================
- Hits 30348 631 -29717
+ Misses 4016 73 -3943
+ Partials 1153 31 -1122 |
@ChristineTChen @masci Any feedback regarding this PR? |
pginstance can be redundant to the SC's host and port being added here, so removing them
checks bgw metrics first > add `db` tag > then check common
ian28223
force-pushed
the
ianb/postgres_add_pginstancetag
branch
from
March 13, 2019 02:46
40d28b4
to
cf1ac33
Compare
adding again after a rebase/conflict
rabased and made some adjustments due to some conflicts |
gzussa
approved these changes
Mar 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
zippolyte
changed the title
[postgres] adds pg_instance tag to metrics
adds pg_instance tag to metrics
Apr 1, 2019
Followed up by #3467 |
zippolyte
changed the title
adds pg_instance tag to metrics
Add Apr 5, 2019
server
tag to metrics and service_check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds pg_instance:<host|host-port> tag to metrics to distinguish which instance the metric came from.
Given a host (e.g.
dd-host1
) that connects to multiple remote PG instances:metric submitted from each instance are identical and has no reference to which pg instance they were queried from.
With the pg_instance tag, it would look like:
Motivation
Realized that i could not distinguish which metrics are coming from what instance.
Review checklist
no-changelog
label attachedAdditional Notes
Anything else we should know when reviewing?