Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the kong integration with log instruction #2935

Merged
merged 11 commits into from
Feb 25, 2019
Merged

Update the kong integration with log instruction #2935

merged 11 commits into from
Feb 25, 2019

Conversation

NBParis
Copy link

@NBParis NBParis commented Jan 11, 2019

What does this PR do?

Add the kong log integration

Motivation

integration was added on the log side

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Anything else we should know when reviewing?

@NBParis NBParis requested review from a team as code owners January 11, 2019 18:18
kong/README.md Outdated Show resolved Hide resolved
kong/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested some grammar/spelling changes

cswatt and others added 3 commits January 21, 2019 13:49
Co-Authored-By: NBParis <nils.bunge@datadoghq.com>
Co-Authored-By: NBParis <nils.bunge@datadoghq.com>
@NBParis
Copy link
Author

NBParis commented Jan 21, 2019

@cswatt @ruthnaebeck made the changes. Feel free to review.

l0k0ms
l0k0ms previously approved these changes Jan 21, 2019
Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌 @gzussa I updated the configuration file for Kong, do you like the new ssl_validation parameter description ?

cswatt
cswatt previously approved these changes Jan 21, 2019
@stale
Copy link

stale bot commented Feb 23, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

@stale stale bot added the stale label Feb 23, 2019
@ofek
Copy link
Contributor

ofek commented Feb 23, 2019

@l0k0ms @cswatt @ruthnaebeck I rebased to resolve conflicts. Can you please look again?

Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@gzussa gzussa merged commit 5b164e6 into master Feb 25, 2019
@gzussa gzussa deleted the nils/kong branch February 25, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants