Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish Python3 Support #2949

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Finish Python3 Support #2949

merged 1 commit into from
Jan 15, 2019

Conversation

nmuesch
Copy link
Contributor

@nmuesch nmuesch commented Jan 15, 2019

What does this PR do?

Finish Py3 support for postgres by only using zip when iterating.

Motivation

ddev validate py3 postgres was failing
PY2 bas the built in zip return the whole iterable, but PY3 returns an iterator.
We were only using the return value once anyway, but this ensures it and makes the validation pass.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If PR adds a configuration option, it has been added to the configuration file.

Additional Notes

Anything else we should know when reviewing?

@codecov-io
Copy link

Codecov Report

Merging #2949 into master will increase coverage by 0.56%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2949      +/-   ##
==========================================
+ Coverage   84.95%   85.51%   +0.56%     
==========================================
  Files         662        9     -653     
  Lines       37170      718   -36452     
  Branches     4396       94    -4302     
==========================================
- Hits        31577      614   -30963     
+ Misses       4307       73    -4234     
+ Partials     1286       31    -1255

@nmuesch nmuesch merged commit c79fab1 into master Jan 15, 2019
@nmuesch nmuesch deleted the nick/postgres3 branch January 15, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants