adds channel metrics

[gmmeyer]

What does this PR do?

This adds channel metrics for IBM MQ

Motivation

customer request

Additional Notes

The number of channels metric was requested. There aren't really many other metrics for channels that are exposed, so the only other thing we could do is status.

We let them set the channels so that we can send a warning if a channel is not there. A channel that exists has only two statuses, on and off. A channel that's not there won't trigger anything when we look for the status automatically.

Review checklist (to be filled by reviewers)

• PR title must be written as a CHANGELOG entry (see why)
• Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
• PR must have changelog/ and integration/ labels attached
• Feature or bugfix must have tests
• Git history must be clean
• If PR adds a configuration option, it must be added to the configuration file.

[gmmeyer]

I haven't written tests yet, I'll write them next week

[codecov]

Codecov Report

Merging #3360 into master will increase coverage by 1.95%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #3360      +/-   ##
==========================================
+ Coverage   79.11%   81.07%   +1.95%     
==========================================
  Files         153       10     -143     
  Lines        7747      354    -7393     
  Branches      945       32     -913     
==========================================
- Hits         6129      287    -5842     
+ Misses       1395       60    -1335     
+ Partials      223        7     -216

[zippolyte]

Not sure I understand completely. You're collecting a metric for the number of channels, then checking for the status of each of them, and then checking for the status of specified channels in the config ? Why is that ?

[gmmeyer]

@zippolyte The number of channels metric was requested. There aren't really many other metrics for channels that are exposed, so the only other thing we could do is status.

We let them set the channels so that we can send a warning if a channel is not there. A channel that exists has only two statuses, on and off. A channel that's not there won't trigger anything when we look for the status automatically.

[zippolyte]

Thanks for the explanation. Can you try to factorize a bit the code then ? It feels like a lot of duplication that could be avoided.

[gmmeyer]

Yea I can do that

[zippolyte]

Awesome ! Thanks for the inline comments as well 👍
Let's make sure we don't forget to add tests later.

[gmmeyer]

@zippolyte I did add it to the tests!

[zippolyte]

Let's remove those 3 lines

[codecov]

Codecov Report

Merging #3360 into master will increase coverage by 1.79%.
The diff coverage is 88.09%.

@@            Coverage Diff             @@
##           master    #3360      +/-   ##
==========================================
+ Coverage   79.11%   80.91%   +1.79%     
==========================================
  Files         153       10     -143     
  Lines        7747      351    -7396     
  Branches      945       31     -914     
==========================================
- Hits         6129      284    -5845     
+ Misses       1395       60    -1335     
+ Partials      223        7     -216