Change .container.restarts to be actionnable in a monitor #3417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
kubernetes.containers.restarts
metric is currently collected as a ever-increasing gauge, and tagged bycontainer_id
. This makes the value stay at 1 and change tags every time a container restarts inside a given pod:This makes the metric very hard to use for alerting, while we would expect it to give an actual count of restarts per pod_name/kube_container_name. This PR does the following:
Depends on #3413 , the target branch will be changed back to
master
after the first PR is merged.Monitor example
Testing with 2 then 6 restarts of redis containers on a given host:
Before (gauge)
After
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached