Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default port for kube apiserver metrics auto conf #4785

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Use default port for kube apiserver metrics auto conf #4785

merged 1 commit into from
Oct 16, 2019

Conversation

mfpierre
Copy link
Contributor

What does this PR do?

Use the default value for the API server secure port 6443

Motivation

Easier autodiscovery

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@mfpierre mfpierre requested review from a team as code owners October 16, 2019 11:49
clamoriniere
clamoriniere approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FlorianVeaux FlorianVeaux merged commit a4f12a5 into master Oct 16, 2019
@FlorianVeaux FlorianVeaux deleted the mfpierre/fix-apiserver-metrics-autoconf branch October 16, 2019 12:16
FlorianVeaux pushed a commit that referenced this pull request Oct 16, 2019
@mfpierre @FlorianVeaux
Use default port for kube apiserver metrics auto conf (#4785)
24e1993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clamoriniere clamoriniere clamoriniere approved these changes

Assignees
No one assigned
Labels
integration/kube_apiserver_metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfpierre @clamoriniere @FlorianVeaux