Add channel metrics #5116
Merged
Add channel metrics #5116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
6 tasks
AlexandreYang
force-pushed
the
alex/ibm_mq/additional_queue_and_channel_metrics_2
branch
from
4f9b0af
to
730ef48
Compare
AlexandreYang
commented
Nov 29, 2019
| 'long_retry_count': pymqi.CMQCFC.MQIACH_LONG_RETRY, | ||
| 'long_retry_interval': pymqi.CMQCFC.MQIACH_LONG_TIMER, | ||
| 'long_retry': pymqi.CMQCFC.MQIACH_LONG_RETRY, | ||
| 'long_timer': pymqi.CMQCFC.MQIACH_LONG_TIMER, |
There was a problem hiding this comment.
Note to reviewers: Channel metrics where not submitted previously, so it's ok to rename them.
There was a problem hiding this comment.
I think the originals are more descriptive
There was a problem hiding this comment.
@hithwen Most/all names match the name of the IBM MQ lib constant, should we keep that way for consistency?
There was a problem hiding this comment.
Ok, that makes sense but is this a breaking change?
There was a problem hiding this comment.
@hithwen My initial comment was this :)
Note to reviewers: Channel metrics where not submitted previously, so it's ok to rename them.
AlexandreYang
force-pushed
the
alex/ibm_mq/additional_queue_and_channel_metrics_2
branch
from
730ef48
to
731d264
Compare
hithwen
approved these changes
Dec 11, 2019
AlexandreYang
deleted the
alex/ibm_mq/additional_queue_and_channel_metrics_2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add channel metrics
Motivation
User request.
Additional Notes
Channel metrics where not submitted previously, so it's ok to rename them:
ibm_mq/datadog_checks/ibm_mq/metrics.pycan be constants. That will be done in another PR.Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached