Add new integration Apache Ignite #5767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
ofek
requested changes
Mar 6, 2020
ChristineTChen
requested changes
Mar 6, 2020
l0k0ms
reviewed
Mar 9, 2020
l0k0ms
reviewed
Mar 9, 2020
therve
force-pushed
the
therve/ignite
branch
2 times, most recently
from
5b3e1d3
to
3bbb9c4
Compare
hithwen
reviewed
Mar 16, 2020
hithwen
reviewed
Mar 16, 2020
hithwen
reviewed
Mar 16, 2020
hithwen
reviewed
Mar 16, 2020
ofek
reviewed
Mar 27, 2020
therve
force-pushed
the
therve/ignite
branch
2 times, most recently
from
02ea6ac
to
8f49b64
Compare
ignite/tests/test_check.py
Outdated
| def test_e2e(dd_agent_check): | ||
| instance = {} | ||
| aggregator = dd_agent_check(instance, rate=True) | ||
| metrics = [ |
There was a problem hiding this comment.
Can we move the two metrics list to separate file so the test is more readable?
Co-Authored-By: Christine Chen <ChristineTChen@users.noreply.github.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Julia <611228+hithwen@users.noreply.github.com>
Co-Authored-By: Christine Chen <ChristineTChen@users.noreply.github.com>
ofek
approved these changes
Apr 22, 2020
ChristineTChen
approved these changes
Apr 22, 2020
ChristineTChen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new JMX integration to monitor the Ignite database.