-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to set SNI hostname via the Host
header for RequestsWrapper
#5833
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for docs
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Note that this will not be automatically closed, but the notification will remind us to investigate why there's been inactivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! WDYTA implicitly having it enable persist_connections
?
datadog_checks_base/datadog_checks/base/data/agent_requirements.in
Outdated
Show resolved
Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/http.yaml
Outdated
Show resolved
Hide resolved
Host
header for RequestsWrapper
Good idea. I've added that in |
c510622
to
e362a6d
Compare
What does this PR do?
Adds
tls_use_host_header
parameter to the RequestsWrapper.If set to true, allows the
Host
header will be used to match against SSL Certificate CN or SAN.Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached