Update prometheus_client #6200
Merged
Update prometheus_client #6200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
therve
force-pushed
the
therve/update-prometheus
branch
from
1da9668
to
8a8a86f
Compare
AlexandreYang
requested changes
Mar 31, 2020
ofek
requested changes
Mar 31, 2020
openmetrics/tests/conftest.py
Outdated
| @@ -35,12 +35,13 @@ def poll_mock(): | |||
| g3 = Gauge('metric3', 'memory usage', ['matched_label', 'node', 'timestamp'], registry=registry) | |||
| g3.labels(matched_label="foobar", node="host2", timestamp="456").set(float('inf')) | |||
|
|
|||
| data = ensure_unicode(generate_latest(registry)) | |||
| data = data.replace("_total", "") | |||
There was a problem hiding this comment.
This implies a breaking change, no?
There was a problem hiding this comment.
No, I don't think it does. It implies a breaking change from the prometheus producing metric side that we used in the tests, not in our consumer. Notice that the classes used to generate the data comes from prometheus_client.
There was a problem hiding this comment.
But does that mean users can also produce counter metrics with _total suffix and it won't work with this integration ?
|
See: #3700 |
6 tasks
therve
force-pushed
the
therve/update-prometheus
branch
from
2fdfa66
to
d2692ed
Compare
AlexandreYang
previously approved these changes
Apr 1, 2020
This updates prometheus client library to the latest available version, by removing the change in text_fd_to_metric_families which is breaking our compatibility.
therve
force-pushed
the
therve/update-prometheus
branch
from
d2692ed
to
b59dc79
Compare
therve
force-pushed
the
therve/update-prometheus
branch
from
36bb890
to
3f4fbd0
Compare
AlexandreYang
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates prometheus client library to the latest available version,
by removing the change in text_fd_to_metric_families which is breaking
our compatibility.