Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default template to openmetrics & jmx config #6328

Merged
merged 4 commits into from
Apr 13, 2020
Merged

Add default template to openmetrics & jmx config #6328

merged 4 commits into from
Apr 13, 2020

Conversation

ChristineTChen
Copy link
Contributor

Add init_config/default to openmetrics spec template

@ChristineTChen ChristineTChen requested review from a team as code owners April 13, 2020 15:29
@ChristineTChen ChristineTChen requested a review from a team as a code owner April 13, 2020 15:38
ofek
ofek approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ofek ofek changed the title Add default template to openmetrics config Add default template to openmetrics & jmx config Apr 13, 2020
@codecov
Copy link

codecov bot commented Apr 13, 2020 •
edited
Loading

Codecov Report

Merging #6328 into master will decrease coverage by 4.40%.
The diff coverage is n/a.

Impacted Files Coverage Δ
gearmand/tests/common.py
...checks_base/datadog_checks/base/utils/constants.py
ambari/datadog_checks/ambari/__init__.py
envoy/datadog_checks/envoy/metrics.py
riak/datadog_checks/riak/__init__.py
apache/tests/test_apache.py
system_core/tests/test_integration.py
...e_metrics_server/tests/test_kube_metrics_server.py
marathon/tests/conftest.py
mcache/datadog_checks/mcache/__about__.py
... and 725 more

@ChristineTChen ChristineTChen merged commit 4346296 into master Apr 13, 2020
@ChristineTChen ChristineTChen deleted the cc/update-open-temp branch April 13, 2020 16:08
@AlexandreYang AlexandreYang mentioned this pull request Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@sarah-witt sarah-witt sarah-witt approved these changes

Assignees
No one assigned
Labels
dev/tooling documentation integration/activemq integration/confluent_platform integration/datadog_checks_dev integration/hive integration/jboss_wildfly integration/openmetrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristineTChen @ofek @sarah-witt