Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure bytes for ssl connection #6913

Merged
merged 2 commits into from
Jun 26, 2020
Merged

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Jun 17, 2020

What does this PR do?

Ensure bytes for ssl connection

Motivation

The integration is broken for Python 3 when TLS is used:

2020-06-19 09:17:13 UTC | CORE | WARN | (pkg/collector/python/datadog_agent.go:119 in LogMessage) | ibm_mq:9d243cc47a1f6817 | (ibm_mq.py:44) | cannot connect to queue manager: Python 3 style string (unicode) found but not allowed here: TLS_RSA_WITH_AES_256_CBC_SHA256. Convert to bytes.

Additional Notes

This is a quick fix with simple unit test. I plan to add a e2e test for ssl, but will take more time.

Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, some questions :-)

ibm_mq/datadog_checks/ibm_mq/connection.py Show resolved Hide resolved
ibm_mq/tests/test_ibm_mq_unit.py Show resolved Hide resolved
@AlexandreYang AlexandreYang merged commit 9f1f881 into master Jun 26, 2020
@AlexandreYang AlexandreYang deleted the alex/ibm_mq_ensure_bytes branch June 26, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants