-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure bytes for ssl connection #6913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
AlexandreYang
force-pushed
the
alex/ibm_mq_ensure_bytes
branch
from
June 19, 2020 12:34
c173e40
to
76082df
Compare
github-actions
bot
added
changelog/no-changelog
dependencies
dev/testing
dev/tooling
documentation
integration/active_directory
integration/aerospike
integration/aspdotnet
integration/cloud_foundry_api
integration/datadog_checks_base
integration/datadog_checks_dev
integration/directory
integration/dotnetclr
integration/eks_fargate
integration/exchange_server
integration/flink
integration/gitlab
integration/harbor
integration/ignite
integration/iis
integration/kubernetes_state
integration/kube_apiserver_metrics
integration/mysql
integration/pdh_check
integration/postgres
integration/powerdns_recursor
integration/proxysql
labels
Jun 26, 2020
AlexandreYang
added
changelog/Fixed
and removed
integration/iis
integration/kube_apiserver_metrics
integration/kubernetes_state
integration/mysql
integration/pdh_check
integration/postgres
integration/powerdns_recursor
integration/proxysql
integration/rabbitmq
integration/snmp
integration/sqlserver
integration/vsphere
integration/win32_event_log
integration/windows_service
integration/wmi_check
integration/zk
changelog/no-changelog
dependencies
dev/testing
dev/tooling
documentation
release
labels
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, some questions :-)
hithwen
approved these changes
Jun 26, 2020
florimondmanca
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensure bytes for ssl connection
Motivation
The integration is broken for Python 3 when TLS is used:
Additional Notes
This is a quick fix with simple unit test. I plan to add a e2e test for ssl, but will take more time.