IBM MQ metadata

[steveny91]

What does this PR do?

This PR attempts to add the functionality to have the check pick up the version of the IBM MQ server.

Motivation

Assigned as a embed task

Additional Notes

N/A

Review checklist (to be filled by reviewers)

• Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
• PR title must be written as a CHANGELOG entry (see why)
• Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
• PR must have changelog/ and integration/ labels attached

[mgarabed]

Nice stuff!

[AlexandreYang]

I think there is a big drawback using a shell command, it only works if the agent is running on the MQ Server itself. We should try to get the version via PCF command instead :)

[codecov]

Codecov Report

Merging #6979 into master will increase coverage by 0.40%.
The diff coverage is 70.00%.

Impacted Files	Coverage Δ
ibm_mq/datadog_checks/ibm_mq/config.py	86.95% <0.00%> (ø)
...dog_checks/ibm_mq/collectors/metadata_collector.py	63.88% <63.88%> (ø)
ibm_mq/datadog_checks/ibm_mq/ibm_mq.py	75.71% <71.42%> (ø)
...bm_mq/datadog_checks/ibm_mq/collectors/__init__.py	100.00% <100.00%> (ø)
ibm_mq/tests/common.py	100.00% <100.00%> (ø)
ibm_mq/tests/test_metadata.py	100.00% <100.00%> (ø)
btrfs/datadog_checks/btrfs/__init__.py
datadog_checks_base/tests/test_winpdh.py
cisco_aci/datadog_checks/cisco_aci/tenant.py
..._state/datadog_checks/kubernetes_state/__init__.py
... and 871 more

[steveny91]

I changed up the method of collection to what @AlexandreYang suggested, update the metadata collection test. Please let me know if anything needs changing. Thanks!

[AlexandreYang]

Nice, thx for using PCF command instead. I left few comments. :)

[steveny91]

@AlexandreYang I've updated the check with most of your comments. The only one I left out was the dependency upgrade of pymqi to 1.11.1. For whatever reason, upgrading to 1.11.1 breaks the py2 tests. I get this error when stepping through:

-> self.channel_metric_collector.get_pcf_channel_metrics(queue_manager)
(Pdb) self.channel_metric_collector.get_pcf_channel_metrics(queue_manager)
*** NotImplementedError: Unpack for type ((4,)) not implemented

Not sure if you've come across this error before.

outdated