-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to disable stream api checking in Nginx Plus #7241
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your contribution. The PR looks good overall the only caveat is we need to be retrocompatible and because of that the default value need to be True
Co-authored-by: Julia <611228+hithwen@users.noreply.github.com>
Co-authored-by: Julia <611228+hithwen@users.noreply.github.com>
Hi, you need to sync the config file again, otherwise its good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs green build
@hithwen how can I sync config file once again ?? |
@szibis you need to update to the latest version of |
This reverts commit fe5b623.
I'm very sorry, yesterday we removed some trailing whitespaces from the base templates so you need to rebase with master before syncing (or try applying the suggestion I've left) |
Co-authored-by: Julia <611228+hithwen@users.noreply.github.com>
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
Co-authored-by: Julia <611228+hithwen@users.noreply.github.com>
Co-authored-by: Julia <611228+hithwen@users.noreply.github.com>
Add feature to disable stream Nginx Plus API if no stream in Nginx configuration
With the current integration version, we get a lot of errors in Nginx Plus for calling Stream endpoints stats that does not exist if no Stream defined in Nginx configuration.
Now we will have the ability to disable stream checking in the Datadog integration configuration file.
When
use_plus_api: True
then we need now set alsouse_plus_api_stream: True
to have all covered. This is aligned to values defined for endpoints in the Nginx integration code.changelog/
andintegration/
labels attached