Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Postgres statements to remove information_schema query #8498

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

justiniso
Copy link
Contributor

What does this PR do?

Removes a query to information_schema which requires different permissions from what our documentation grants. This change gets the required columns for querying pg_stat_statements directly from the view/function used.

Motivation

We ran into an issue with later versions of postgres on aurora where the pg_stat_statements view is owned by user rdsadmin and therefore the column names of the view are not exposed in information_schema.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e) -- existing tests cover this change
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

…her than querying information_schema for column names
@ofek ofek merged commit 695e03d into master Feb 1, 2021
@ofek ofek deleted the justiniso/fix-deep-database-monitoring-postgres-v10 branch February 1, 2021 16:26
ofek pushed a commit that referenced this pull request Feb 1, 2021
…her than querying information_schema for column names (#8498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants