Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to convert endianness #8601

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Conversation

FlorianVeaux
Copy link
Member

@FlorianVeaux FlorianVeaux commented Feb 11, 2021

No description provided.

Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small docs question

@@ -127,6 +127,13 @@ files:
value:
example: 6
type: number
- name: convert_endianness
description: |
If you are monitoring IBM MQ remotely and if the agent and the server are using different endianness,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this talking about the Datadog Agent? If so, we capitalize Agent.

@@ -121,6 +121,12 @@ instances:
#
# mqcd_version: 6

## @param convert_endianness - boolean - optional - default: false
## If you are monitoring IBM MQ remotely and if the agent and the server are using different endianness,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment about agent/Agent

Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from docs

@FlorianVeaux FlorianVeaux merged commit e11146a into master Feb 19, 2021
@FlorianVeaux FlorianVeaux deleted the florian/mq_endianess_conversion branch February 19, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants