Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard for ActiveMQ Artemis #8690

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Add dashboard for ActiveMQ Artemis #8690

merged 3 commits into from
Mar 23, 2021

Conversation

mgarabed
Copy link
Member

@mgarabed mgarabed commented Feb 24, 2021

What does this PR do?

Add additional dashboard to ActiveMQ for Artemis specifically.

Dashboard on staging

Updated to blog-like style:
Screen Shot 2021-03-16 at 3 18 22 PM

Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're introducing a new dashboard, should we follow the blog-like format?

@mgarabed
Copy link
Member Author

Good point, wanted to maintain consistency with the existing ActiveMQ dashboard, but migrating them both to a blog-like format would be a good follow up task.

@tobias-zeptio
Copy link

@mgarabed Will this be part of the next release?

@mgarabed
Copy link
Member Author

@mgarabed Will this be part of the next release?

Hi @tobias-zeptio - the integration support for ActiveMQ Artemis should be in the next release, yes. This PR adds specifically the default dashboard for those new metrics, and should be available in the same timeframe.

Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add arrows to the blog blurbs to point which categories/metrics it's referring to? I believe we usually have them on the borders of the dashboard vs the middle.

@mgarabed
Copy link
Member Author

Can we add arrows to the blog blurbs to point which categories/metrics it's referring to? I believe we usually have them on the borders of the dashboard vs the middle.

@ChristineTChen This seems to be a temporary bug with our dashboard rendering. All of those boxes include the appropriate option to include the arrow, they just aren't showing at this time.

@mgarabed mgarabed requested a review from kayayarai March 18, 2021 18:41
@mgarabed mgarabed merged commit 398341d into master Mar 23, 2021
@mgarabed mgarabed deleted the mg/artemis-dash branch March 23, 2021 13:07
@tobias-zeptio
Copy link

Great that this has been released now. But, can we add a tag filter to the dashboard. Now, I needed to clone it and add a $cluster_name filter.

  "template_variables": [
    {
      "name": "cluster_name",
      "default": "husqiot-eks-dev",
      "prefix": "cluster_name"
    }
  ]

and then {$cluster_name} for each metric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants