Add runtime configuration validation #8943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
force-pushed
the
ofek/sync_config_models_kong
branch
from
3aaee8a
to
a8bc90a
Compare
fanny-jiang
requested changes
Oct 28, 2021
| kerberos_hostname: Optional[str] | ||
| kerberos_keytab: Optional[str] | ||
| kerberos_principal: Optional[str] | ||
| kong_status_url: str |
There was a problem hiding this comment.
Suggested change
| kong_status_url: str | |
| kong_status_url: Optional[str] |
Since the check also offers an openmetrics option. The spec.yaml will also need updating.
ghost
added
the
|
The |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
fanny-jiang
approved these changes
Nov 8, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2021
* Sync config models * re-sync * address * sync 2fa18b7
hithwen
reviewed
Nov 15, 2021
| @@ -8,13 +8,13 @@ files: | |||
| - template: instances | |||
| options: | |||
| - name: kong_status_url | |||
| required: true | |||
There was a problem hiding this comment.
But it is required
integrations-core/kong/datadog_checks/kong/kong.py
Lines 49 to 50 in e668209
There was a problem hiding this comment.
Oh, but only if openmetrics_endpoint is not defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds config models from #8675