Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore config models from coverage #9012

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Conversation

coignetp
Copy link
Contributor

What does this PR do?

There Sync config models PRs are adding a folder to every integration. However, this folder is validated the the ddev command, so codecov does not consider it tested.

Having these folders it the code coverage seems irrelevant.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's only modify

with a TODO comment saying to remove when we drop Python 2 and are then able to use them

@coignetp coignetp merged commit ddb2745 into master Mar 23, 2021
@coignetp coignetp deleted the paul/codecov-ignore-models branch March 23, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants