Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurability of the ignore_metrics option #9161

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

CharlyF
Copy link
Contributor

@CharlyF CharlyF commented Apr 14, 2021

What does this PR do?

The option to ignore metrics from the /metrics/cadvisor endpoint was hardcoded. This PR allows users to extend the list should they choose to not collect a subset of metrics.

Motivation

Customer FR.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@CharlyF CharlyF merged commit cfd04ff into master Apr 14, 2021
@CharlyF CharlyF deleted the charlyf/cadvisor_ignore_metrics_extend branch April 14, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants