Exclude EXPLAIN queries from pg_stat_statements
#9358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
alexandre-normand
previously approved these changes
May 14, 2021
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more.
|
djova
force-pushed
the
djova/postgres-exclude-explain-pg-stat-statements
branch
from
2efbbc1
to
99737c8
Compare
Update the collection of postgres query metrics to exclude `EXPLAIN` queries. If deep database monitoring is enabled and we are collecting execution plans, then there will be at least one tracked EXPLAIN statement for every unique normalized query we encounter. Since these statements are not used in the product we exclude them from collection. This updates postgres to have the same behavior as mysql, where we do the same exclusion for query metrics.
djova
force-pushed
the
djova/postgres-exclude-explain-pg-stat-statements
branch
from
68a7eca
to
d000e84
Compare
ofek
approved these changes
May 17, 2021
ofek
changed the title
EXPLAIN queries from pg_stat_statements
daanleenders
pushed a commit
to daanleenders/integrations-core
that referenced
this pull request
May 19, 2021
* postgres exclude EXPLAIN queries from pg_stat_statements Update the collection of postgres query metrics to exclude `EXPLAIN` queries. If deep database monitoring is enabled and we are collecting execution plans, then there will be at least one tracked EXPLAIN statement for every unique normalized query we encounter. Since these statements are not used in the product we exclude them from collection. This updates postgres to have the same behavior as mysql, where we do the same exclusion for query metrics. * escape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the collection of postgres query metrics to exclude
EXPLAINqueries.Motivation
If deep database monitoring is enabled and we are collecting execution plans, then there will be at least one tracked EXPLAIN statement for every unique normalized query we encounter. Since these statements are not used in the product we exclude them from collection.
This updates postgres to have the same behavior as mysql, where we do the same exclusion for query metrics.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached