Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config validation #9781

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Fix config validation #9781

merged 1 commit into from
Jul 27, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jul 27, 2021 •
edited by hithwen
Loading

Motivation

#9739 changes model validation to use display_default instead of default.

This PR makes sure that all display_default values are actually valid values.

@ofek ofek requested review from a team as code owners July 27, 2021 14:44
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #9781 (3aa9ce5) into master (a9470de) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
vsphere 89.77% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek merged commit aef3799 into master Jul 27, 2021
@ofek ofek deleted the ofek/c branch July 27, 2021 15:32
@FlorianVeaux FlorianVeaux mentioned this pull request Aug 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen approved these changes

Assignees
No one assigned
Labels
documentation integration/vsphere
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofek @hithwen