-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set a default statement timeout for postgres to 5s #9847
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
justiniso
changed the title
Set a default statement timeout for postgres
Set a default statement timeout for postgres to 2s
Aug 4, 2021
ghost
added
the
documentation
label
Aug 4, 2021
Update spec
justiniso
force-pushed
the
justiniso/statement-timeout-postgres
branch
from
August 5, 2021 14:30
5eaa19a
to
3c28131
Compare
justiniso
changed the title
Set a default statement timeout for postgres to 2s
Set a default statement timeout for postgres to 5s
Aug 5, 2021
ofek
requested changes
Aug 5, 2021
ruthnaebeck
previously approved these changes
Aug 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for docs
Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
ofek
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the Postgres integration to set a default timeout of 5s on queries. Based on internal benchmarking, this should be a wide margin to ensure we mitigate performance impact in the worst case scenarios, while still ensuring customers have metrics.
Motivation
Datadog strives to provide high fidelity telemetry while guaranteeing the lowest possible performance impact by the agent. While the integrations do not run any queries that should exceed a 5s execution time, there are certain failure scenarios on databases that could result in all queries being slow and consuming more resources than a monitoring tool should–especially on a loaded database.
Additional Notes
I believe the biggest risk in changing this behavior is the impact on long-running custom queries. However the benefit to risk ratio is very hight.
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached