Use dedicated instance logger for connection messages #9887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
fanny-jiang
reviewed
Aug 12, 2021
| import pymqi | ||
|
|
||
| logger = logging.getLogger(__file__) |
There was a problem hiding this comment.
Not really a suggestion, but wanted to check my understanding: Is the python logging package being used here instead of the dedicated check instance logger because this is a unit test against the check? Since the the check's methods now expect a logger argument.
There was a problem hiding this comment.
good catch, yeah we don't type check tests/ afaik & was easier to do this than creating a check instance just for the logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add ability to disambiguate, see:
vs: