Skip to content
This repository has been archived by the owner on Jan 23, 2020. It is now read-only.

Set failed event to alert_type error #124

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Set failed event to alert_type error #124

merged 1 commit into from
Oct 22, 2018

Conversation

sjenriquez
Copy link
Contributor

@sjenriquez sjenriquez commented Oct 22, 2018 •
edited
Loading

alert_type should be error not failed according to our API documentation.

truthbk
truthbk approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦

@sjenriquez sjenriquez merged commit 52cbb4c into master Oct 22, 2018
@sjenriquez sjenriquez deleted the scott/event-error branch October 22, 2018 15:29
@sjenriquez sjenriquez restored the scott/event-error branch October 22, 2018 19:30
@sjenriquez sjenriquez deleted the scott/event-error branch October 22, 2018 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@truthbk truthbk truthbk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjenriquez @truthbk