This repository has been archived by the owner on Jan 23, 2020. It is now read-only.
Adds whitelist configuration option (again) #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
force-pushed
the
zeller/rebase-whitelist
branch
from
597bf52
to
4cc7f04
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix: #78
Still not entirely sure why the normalization of the names breaks it, we should probably look into it in greater detail. Essentially when using the normalized name to determine if the job was tracked, I believe we were getting consistently getting a False value in some segements of the code.
Additional Notes
Even stranger due to the fact the
isJobTrackedis mocked here!