Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) feature: add observers() method in environments #216

Merged
merged 5 commits into from
Jan 25, 2022

Conversation

YuriCat
Copy link
Contributor

@YuriCat YuriCat commented Oct 20, 2021

Each environment should determine the observers at each turn.

Next problem: How do you use the observation argument, and is it necessary?

@ikki407
Copy link
Member

ikki407 commented Jan 24, 2022

It's simple (I think observation argument is not necessary.) I expect that users can understand observers() function than before.

Question: If a user defined a player in both turn_players and observers, should HandyRL detect it or raise an error?
Answer: no problem

@ikki407
Copy link
Member

ikki407 commented Jan 24, 2022

Should we add this in the document?
https://github.com/DeNA/HandyRL/blob/master/docs/custom_environment.md

@ikki407 ikki407 merged commit a7f13b7 into DeNA:develop Jan 25, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants