fix: trainer for non trainable model #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikki407
reviewed
Jan 24, 2022
| @@ -349,8 +349,8 @@ def shutdown(self): | |||
|
|
|||
| def train(self): | |||
| if self.optimizer is None: # non-parametric model | |||
| print() | |||
| return | |||
| time.sleep(0.1) | |||
There was a problem hiding this comment.
This is because without time.sleep(), train() will be called incessantly.
It may be better to prevent calling this function.
There was a problem hiding this comment.
The problem is that the training epoch will not proceed until train() is called.
|
LGTM |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a bug, and we don't need any Batcher if self.optimizer is
None.