Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: assign cumulative worker index #246

Merged
merged 1 commit into from
Jan 31, 2022
Merged

feature: assign cumulative worker index #246

merged 1 commit into from
Jan 31, 2022

Conversation

YuriCat
Copy link
Contributor

@YuriCat YuriCat commented Jan 24, 2022 •
edited
Loading

Worker IDs should be cumulative, or the initial states may be covered.
I think I had implemented this feature before...?

@YuriCat YuriCat changed the title feature: assing cumulative worker index feature: assign cumulative worker index Jan 24, 2022
@ikki407
Copy link
Member

ikki407 commented Jan 25, 2022

LGTM

@YuriCat
Copy link
Contributor Author

YuriCat commented Jan 25, 2022

However, not a good match for #245

@YuriCat YuriCat mentioned this pull request Jan 26, 2022
Open
@YuriCat YuriCat force-pushed the feature/cumulative_worker_id branch from 103dca1 to 897ea32 Compare January 31, 2022 03:52
@ikki407 ikki407 merged commit 233f11c into DeNA:develop Jan 31, 2022
@ikki407 ikki407 mentioned this pull request Jan 31, 2022
Merged
@YuriCat YuriCat deleted the feature/cumulative_worker_id branch February 11, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuriCat @ikki407