New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: since critic is not necessary, it should be None at default #271

Merged

ikki407 merged 1 commit into DeNA:develop from YuriCat:chore/critic_default_none

Feb 8, 2022

Contributor

YuriCat commented Feb 7, 2022

I don't think it's an important point, though.


          chore: since critic is not necessary, it should be None at default

e43df89

Member

ikki407 commented Feb 8, 2022 •

edited

Loading

So far, when exec_match() is used, critic is not used in many cases. We can change it.

ikki407 merged commit 9aa67db into DeNA:develop

YuriCat deleted the chore/critic_default_none branch

February 11, 2022 17:59

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet