Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix company name replacement method #10

Merged

Conversation

VeyronSakai
Copy link
Contributor

@VeyronSakai VeyronSakai commented Mar 24, 2024

Overview

  • Fixed an issue where the company name was not properly replaced with the repository owner's name when generating a repository by Use this template.
    • For example, when I generated a repository, an unnecessary Co., Ltd was added at the end, such as VeyronSakai Co., Ltd.
  • I thought it would be necessary to replace .editorconfig as well, so I did that.

Operation Confirmation

I added the same changes as this PR to the fork version of this repository, VeyronSakai/RoslynAnalyzerTemplate, and generated a repository, DummyRoslynAnalyzer2 by Use this template, and made sure that the names were replaced appropriately.

Template cleanup commit


Contribution License Agreement

@VeyronSakai VeyronSakai marked this pull request as ready for review March 24, 2024 10:33
@VeyronSakai VeyronSakai requested a review from a team as a code owner March 24, 2024 10:33
@Kuniwak
Copy link
Member

Kuniwak commented Mar 25, 2024

@VeyronSakai Thank you for the contribution!

@Kuniwak Kuniwak merged commit 5ef64fa into DeNA:master Mar 25, 2024
2 checks passed
@VeyronSakai VeyronSakai deleted the fix/template-cleanup/replace-company-name branch March 25, 2024 03:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants