build(@vtmn/svelte): inject CSS to dist folder by switching to PostCSS
#1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tlahey
added
enhancement 🚀
Tlahey
force-pushed
the
import-css-dist
branch
2 times, most recently
from
824cc3e
to
1e100c2
Compare
lauthieb
force-pushed
the
main
branch
2 times, most recently
from
b2ba18f
to
1605e93
Compare
lauthieb
changed the title
lauthieb
changed the title
dist folder by switching to PostCSS
|
We need a fix from svelte to merged this PR in the futur. |
Tlahey
force-pushed
the
import-css-dist
branch
3 times, most recently
from
286b1db
to
bdb3f46
Compare
AxelPeter
reviewed
Aug 9, 2022
Tlahey
force-pushed
the
import-css-dist
branch
from
bdb3f46
to
1fb60f2
Compare
AxelPeter
previously approved these changes
Aug 17, 2022
Tlahey
force-pushed
the
import-css-dist
branch
from
28e2952
to
d2749de
Compare
Tlahey
added
Publish canary 🐥
|
🐥 Canary published successfully ! |
Tlahey
added
Publish canary 🐥
Tlahey
force-pushed
the
import-css-dist
branch
from
a22525c
to
e97229f
Compare
github-actions
bot
removed
the
Publish canary 🐥
Tlahey
force-pushed
the
import-css-dist
branch
from
e97229f
to
eb4ec26
Compare
Tlahey
force-pushed
the
import-css-dist
branch
from
eb4ec26
to
2cc7ea4
Compare
AxelPeter
approved these changes
Aug 19, 2022
|
@lauthieb it's ok for us, we can push it :) |
lauthieb
approved these changes
Aug 19, 2022
lauthieb
approved these changes
Aug 19, 2022
|
Thanks a lot @Tlahey & @AxelPeter for this great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the rollup configuration.
Switch to postcss to insert the
@imported css into the dist folder.This enhancement doesn't required anymore the
@vtmn/css-*as dependencies.In the dist output with this changes :
rollup-plugin-terserin order to minify the bundlerollup-plugin-css-onlytorollup-plugin-postcss