Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@vtmn/react, @vtmn/vue): timeout enhancement #1483

Merged
merged 2 commits into from
Feb 21, 2024
Merged

feat(@vtmn/react, @vtmn/vue): timeout enhancement #1483

merged 2 commits into from
Feb 21, 2024

Conversation

Tlahey
Copy link
Contributor

@Tlahey Tlahey commented Feb 15, 2024 •
edited
Loading

Changes description

Refer to #1482

Context

Enhancement of the timeout, it is now possible to set a timeout form 0 to Infinity

Update the VtmnAlert / VtmnSnackbar / VtmnToast on React / Vue in order to match the Svelte logic.
Also update the storybook.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on related showcases.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

  • No

Other information

@Tlahey Tlahey requested review from thibault-mahe and a team as code owners February 15, 2024 15:41
@Tlahey Tlahey added enhancement 🚀 New feature or request React 🔵 Related to React components library assets 🏞 Related to assets community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community labels Feb 15, 2024
lauthieb
lauthieb requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@lauthieb lauthieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Tlahey for this contrib!
For me it seems to be ok with just few changes suggestions. I'll wait for @thibault-mahe's review to be sure / for double-checking 👀

packages/showcases/vue/stories/components/overlays/VtmnSnackbar/VtmnSnackbar.stories.js Outdated Show resolved Hide resolved
packages/showcases/vue/stories/components/overlays/VtmnToast/VtmnToast.stories.js Outdated Show resolved Hide resolved
thibault-mahe
thibault-mahe previously approved these changes Feb 21, 2024
View reviewed changes
@Tlahey
Copy link
Contributor Author

Tlahey commented Feb 21, 2024

Thanks @lauthieb & @thibault-mahe
I've done the changes + more clean on the component on another commit on the PR
Let me know ^^

@lauthieb lauthieb linked an issue Feb 21, 2024 that may be closed by this pull request
feat: Improve the management of the timeout on overlay components #1482
Closed
@lauthieb lauthieb merged commit 135c6dd into main Feb 21, 2024
5 checks passed
@lauthieb lauthieb deleted the feat/overlay-management branch February 21, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-mahe thibault-mahe thibault-mahe approved these changes

@lauthieb lauthieb lauthieb approved these changes

Assignees

@Tlahey Tlahey

Labels
assets 🏞 Related to assets community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community enhancement 🚀 New feature or request React 🔵 Related to React components library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Improve the management of the timeout on overlay components
3 participants
@Tlahey @thibault-mahe @lauthieb